search

balderdashy / waterline-adapter-tests

API integration tests for Waterline adapters
MIT License
16 stars 41 forks source link

Vagrant configuration for testing database adapters on a VM. #81

Closed marnusw closed 9 years ago

marnusw commented 9 years ago

When proposing changes to the tests they need to be run against all the core adapters and thus all the databases have to be installed on the host. This is not always desirable. My proposal is to use a Vagrant VM where the databases can be installed automatically in a sandboxed environment.

See the updates in the main README.md for more details on how this will work.

At the moment all core adapter databases except PostgreSQL are installed correctly. File permission issues are giving me headaches with Postgres, but if you like the solution I'll keep struggling with it until I find a solution. Then it should be ready to merge.

devinivy commented 9 years ago

Hey, this is some great stuff. I wish I had some pointers for Postgres... it can definitely be a pain! @tjwebb isn't there some Postgres knowledge at balderdash? Who might be able to help?

dmarcelino commented 9 years ago

@marnusw, this is awesome! Thanks for going through all the trouble to create this.

I only have one very little minor suggestion: move the the steps necessary to run vagrant from the main README to, for example, .puppet/README.md. Leave the intro and then add a link to the steps. The reason I suggest this is that we don't scare or put off people with so much vagrant stuff since it's optional.

marnusw commented 9 years ago

So I got PostgreSQL working too and I just started up a fresh Vagrant VM and ran all the tests to get the results below. I believe that means this is ready to merge! From there I'll confirm that the other changes in my other PRs work as expected for all the adapters.

The following db versions are installed on the VM:

 -----------------------------------
| core modules            | version |
|-------------------------|---------|
| waterline               | 0.10.23 |
| - anchor                |  0.10.2 |
| - waterline-schema      |  0.1.17 |
| waterline-adapter-tests | 308c387 |
 -----------------------------------

 ------------------------------------------------------------------
| adapter          | version | result | failed | total | wl-sequel |
|------------------|---------|--------|--------|-------|-----------|
| sails-postgresql | 30317cd | passed |      0 |   339 |     0.4.0 |
| sails-memory     | c7b0610 | passed |      0 |   314 |           |
| sails-disk       | e95628b | passed |      0 |   314 |           |
| sails-mongo      | 021ec02 | passed |      0 |   314 |           |
| sails-mysql      | f6e27d4 | passed |      0 |   339 |     0.4.0 |
| sails-redis      | 72ced91 | passed |      0 |   232 |           |
 -------------------------------------------------------------------
devinivy commented 9 years ago

Beautiful, thank you! I see you also took care of @dmarcelino's concerns. I think it's good to go! :+1: :+1:

dmarcelino commented 9 years ago

Thanks @marnusw!