balderdashy / waterline-adapter-tests

API integration tests for Waterline adapters
MIT License
16 stars 41 forks source link

Add failing test for mysql populating with limit incorrectly. #83

Open devinivy opened 9 years ago

devinivy commented 9 years ago

See issue over at https://github.com/balderdashy/waterline-sequel/issues/53.

dmarcelino commented 9 years ago

I agree with the test, that should definitely pass: :+1:

jelhan commented 8 years ago

What happened to this PR? While working on a performance improvement at https://github.com/balderdashy/sails-mysql/issues/291 I noticed that limit, sort and skip options for populate() aren't covered by tests. This is not covering all use cases but it's a start.