search

balderdashy / waterline-cursor

Association/subquery helper
1 stars 11 forks source link

Calling synchronous function in async.eachSeries causes maximum call stack error #2

Closed ilia-khaustov closed 9 years ago

ilia-khaustov commented 9 years ago

More of this bug here - https://github.com/balderdashy/waterline/issues/733

There is synchronous call in buildChildBuffers function in the file populateBuffers.js, line 68. This problem is widely covered here - https://github.com/caolan/async/pull/588. I guess it would be enough to change line 68 from nextParent() to async.setImmediate(nextParent).

mikermcneil commented 9 years ago

would be enough to change line 68 from nextParent() to async.setImmediate(nextParent).

Perfect- PR welcome, thanks!

ilia-khaustov commented 9 years ago

What do you mean by PR? Fun fact: Github is blocked in Russia due to a number of texts describing suicide methods.

2014-12-04 0:18 GMT+07:00 Mike McNeil notifications@github.com:

would be enough to change line 68 from nextParent() to async.setImmediate(nextParent).

Perfect- PR welcome, thanks!

— Reply to this email directly or view it on GitHub https://github.com/balderdashy/waterline-cursor/issues/2#issuecomment-65449545 .

devinivy commented 9 years ago

I moved your first comment over to #3 where there is some more conversation. Closing this as a duplicate.

Also, PR stands for "pull request" :)