search

balderdashy / waterline-docs

WARNING: The content in this repo is out of date! See https://github.com/balderdashy/sails-docs for the most up-to-date documentation
452 stars 161 forks source link

Added documentation for grouping and aggregation. #107

Closed kevinob11 closed 8 years ago

kevinob11 commented 8 years ago

Documentation for sql groupBy, average, sum, min, and max.

devinivy commented 8 years ago

This is very nice! Thank you for putting this together. One note– I think it would make sense not to reference the SQL functions used to perform the aggregation. The implementation details are up to the adapter, and will naturally vary adapter to adapter.

kevinob11 commented 8 years ago

Good point, I was thinking they were SQL specific for now, but whether they are or not the goal is that they will be cross adapter. I'll make the change shortly.

kevinob11 commented 8 years ago

Ok I went ahead and removed references to columns, pulled out the SQL specific query language references and made a reference to the SQL Interface in the adapter tests. Let me know how it looks now!

kevinob11 commented 8 years ago

@devinivy anything else in here or can we get this merged?

particlebanana commented 8 years ago

@kevinob11 looks good to me. Any additional changes needed (if any) can be submitted as additional PR's later.

kevinob11 commented 8 years ago

Thanks @particlebanana

devinivy commented 8 years ago

:+1: :)