search

balderdashy / waterline-sequel

A SQL generator for use in Waterline Adapters
MIT License
16 stars 61 forks source link

#25: WhereBuilder.single returns incorrect data type if no queryObject given #26

Closed bradshja closed 9 years ago

bradshja commented 9 years ago

This fixes the bug I experienced where WhereBuilder can return a string instead of an object and confuse calling code. I think there might be more cases like this in the where builders.

dmarcelino commented 9 years ago

Closed and reopen to run the integration tests.

For reference this issue fixes #25.

devinivy commented 9 years ago

I think there might be more cases like this in the where builders. Did we get to the bottom of that? Should we open an issue to look into it?

mofux commented 9 years ago

I am also running into a problem with populate that is suffering from this problem. Will this PR be implemented with the next release?

devinivy commented 9 years ago

@dmarcelino I think this can safely be merged. Is this waiting on anything you know of?

dmarcelino commented 9 years ago

I was awaiting a second opinion, thanks @devinivy!

dmarcelino commented 9 years ago

Thanks @bradshja!

@mofux, this will be released in 0.3.1 (#43).