balderdashy / waterline-sequel

A SQL generator for use in Waterline Adapters
MIT License
16 stars 61 forks source link

Add integration-tests to waterline-sequel (circleci.com) #34

Closed dmarcelino closed 9 years ago

dmarcelino commented 9 years ago

Pretty much what has been said and discussed in #32 but in this version the integration tests run on circleci.com (instead of travis) which allows us for separate badges between unit and integration tests:

Circle CI

@particlebanana, I'll need you to add waterline-sequel to circleci.com and configure any github integrations please (it requires an owner). This will give us the best of both worlds! :smiley:

These tests have the same purpose as those added in balderdashy/waterline-adapter-tests#36 (click for details). These test sails-mysql and sails-postgresql edge versions against waterline-sequel edge version. They differ from the tests already existing in sails-mysql and sails-postgresql in the sense that those only test against waterline-sequel stable. Thus these tests are useful for waterline-sequel developers and to assess their PRs.

First paragraph breakdown in table format:

project tests waterline-sequel version sails-mysql / sails-postgresql version
sails-mysql stable edge
sails-postgresql stable edge
waterline-sequel edge edge

Example build: https://circleci.com/gh/dmarcelino/waterline-sequel/9

devinivy commented 9 years ago

You are a saint.

dmarcelino commented 9 years ago

I'm glad you like it, if the use of these becomes successful we can think in setting up the same for waterline core where circleci would run integration tests against every official adapter for every waterline core PR / master commit.

particlebanana commented 9 years ago

Ok @dmarcelino I setup the hook for circleci not sure if there is anything else I need to configure for it though.

dmarcelino commented 9 years ago

@particlebanana, It's working perfectly! You can see in this PR, below:

 ci/circleci — Your tests failed
 continuous-integration/travis-ci/pr — The Travis CI build passed
 continuous-integration/travis-ci/push — The Travis CI build passed

Which is correct since there is a broken test in the MySQL adapter:

Association Interface Belongs To Association .find() should return customer when the populate criteria is added:
     Uncaught AssertionError: false == true

It's also broken on the sails-mysql build L148 , raised balderdashy/sails-mysql#202.

@devinivy, @tjwebb, I think we are ready to merge this PR!

dmarcelino commented 9 years ago

Thanks @devinivy