search

balderdashy / waterline-sequel

A SQL generator for use in Waterline Adapters
MIT License
16 stars 61 forks source link

Lower value for processObject on sensitive #41

Closed RWOverdijk closed 9 years ago

RWOverdijk commented 9 years ago

Lower value for processObject on sensitive

dmarcelino commented 9 years ago

I'm good with this :white_check_mark:

@devinivy, can you take a second look?

For reference this fixes #39.

devinivy commented 9 years ago

Yeah, it looks right to me. I'm not familiar with the reason this needed fixing, though.

dmarcelino commented 9 years ago

The bug was introduced between 0.2 and 0.3 with the Feature/filter by children PR: #27.

More specifically the bellow line was deleted during the PR changes https://github.com/balderdashy/waterline-sequel/pull/27/files#diff-9fad2d09c9989920cbf45599c3e6eabcL371:

obj[key] = obj[key].toLowerCase();