Open anotherpit opened 8 years ago
Moreover, according to its tests the fellow waterline-criteria library already supports this syntax for and
clause.
Any thoughts on this PR, guys?
@anotherpit I dig it, sorry haven't had time to get into it. We also need some tests in waterline-adapter-tests to show it works in adapters not using wl-sequel such as mongo, etc.
@anotherpit also this is supported in the updated criteria/query syntax I'm working on.
This would be nice to see get merged. Though, we get around this issue, with the mongo adapter, by using $and
for now.
Any status on this.. ?
And btw thanks @jgeurts, you made my day with
we get around this issue, with the mongo adapter, by using $and for now.
@anotherpit Oh my god! This is beautifully done! This is exactly what I was looking for for over 2 months! It is so banal that I can't believe this wasn't done from the beginning. When will this be merged already? It is one of the most basic features for a SQL adapter.
Yes! We needed this for some of our queries as well. I was about to post a PR with this fix, but @anotherpit did a great job and included tests!
it seems { and:[] }
is supported in Sails and waterline-criteria, but just dies here.
I'd love to see this merged soon.
...which also gives you a support for nested and mixed
and
andor
clauses. Like these:Effectively closes https://github.com/balderdashy/waterline/issues/828