search

baldram / ESP_VS1053_Library

A library for VS1053 MP3 Codec Breakout adapted for Espressif ESP8266 and ESP32 boards.
https://platformio.org/lib/show/1744/ESP_VS1053_Library
GNU General Public License v3.0
114 stars 36 forks source link

Ring buffer demo #54

Open fabitom opened 4 years ago

fabitom commented 4 years ago

Here is simple ring buffer demo based on Edzelf/ESP32-Radio

baldram commented 4 years ago

@fabitom Thank you for the PR. Is your feature branch merged with the latest master? I see file changes from the other PR which is already merged to master. So it's some extra noise in this PR. I know it will be theoretically ignored while merging.

fabitom commented 4 years ago

right, I just made ring-buffer-demo branch based on previous. But there was no changes. Should I fork again ? what is right way ? I'm not an expert git ;(

baldram commented 4 years ago

Should I fork again ? what is the right way?

Definitely not. Just merge the stuff from master to your feature branch. It would be something like described here. So the point 1 of this answer. The "feature" is your branch "ring-buffer-demo". Please do a local backup of the folder ;-) Nothing wrong should happen, just in case.

Github describes it also here, but I guess you don't use this GithubDesktop whatever it is.

PS: After all, the PR should be updated, of course.