search

baldram / ESP_VS1053_Library

A library for VS1053 MP3 Codec Breakout adapted for Espressif ESP8266 and ESP32 boards.
https://platformio.org/lib/show/1744/ESP_VS1053_Library
GNU General Public License v3.0
114 stars 36 forks source link

Get Chip Version and enable Stream Mode #79

Closed Dr-Dawg closed 3 years ago

Dr-Dawg commented 3 years ago

Get Chip Version and enable Stream Mode - proposed changes to VS1053.cpp and VS1053.h

baldram commented 3 years ago

Thank you for this change @Dr-Dawg . This looks awesome! 🤩

How about your earlier suggestion mentioned here: https://github.com/baldram/ESP_VS1053_Library/discussions/66#discussioncomment-1210542 and here https://github.com/baldram/ESP_VS1053_Library/discussions/66#discussioncomment-1222558 about adjusting examples? Or should I do it in a separate change?

Probably within this change we're able to adjust examples to use it like this:

if (player.getChipVersion() == 4) { // Only perform an update if we really are using a VS1053, not. eg. VS1003
  player.loadDefaultVs1053Patches(); 
}

We can also update example in README.md here: https://github.com/baldram/ESP_VS1053_Library#usage

What do you think?

Dr-Dawg commented 3 years ago

Sounds good. I'll do that..

Dr-Dawg commented 3 years ago

Done. I updated the Readme (also changed three minutes to three seconds), the examples, and renamed vs1053b-patches.plg to vs1053b-patches.h

baldram commented 3 years ago

All right, thanks for changing this plg to h, so I guess you had an opportunity to test it, that is not causing issues anymore. In a separate change I will rename also other plg files to h for consistency, and to avoid this already known issue. Thanks also for catching this little bug in readme about minutes 😄

Thank you 👍