baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
8.62k stars 1.3k forks source link

Improve AArch64-only device Android handling #3276

Closed cmannett85-arm closed 3 months ago

cmannett85-arm commented 3 months ago

On Pixel 8 phones we were seeing 'INSTALL_FAILED_NO_MATCHING_ABIS' on stdout but it was being checked on stderr only.

The lack of 32bit support is detected again from CheckAndroidServerVersion(..) but it only prints to the log, no logic changes occur. This then caused the 'force queryable' checking to be performed on a not-installed APK which ended up returning ResultCode::AndroidAPKVerifyFailed - which isn't really true.

The change is to check for INSTALL_FAILED_NO_MATCHING_ABIS on stdout too, and if that check still fails then the later check will bypass verfiication keeping the existing Succeeded result.