Closed KacperZielinski-Intel closed 3 months ago
This PR clashes with ongoing work - see #3271 - so I'm going to close it. You're free to keep this code locally on your branch, though note that soon it will likely conflict quite significantly.
In future if you're going to work on such a large feature like this I strongly recommend that you communicate first to check that there isn't any other work happening already that might clash, and that the changes you are making are in the right direction and desired. That prevents any wasted effort that happens from working on code changes only to find that they aren't something that is wanted upstream.
If you'd like to contribute to this functionality you might get in touch with @cmannett85-arm who's currently working on landing code.
Description
Enable support for
VK_KHR_ray_query
, and fix currentVK_KHR_acceleration_structure
implementation.This pull request contains minimal functionality set for capturing apps that use
VK_KHR_ray_query
.Missing features:
SPV_KHR_ray_query
types.Although, disassembly of such shaders is working correctly;
VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR
descriptors sets in functions:VulkanReplay::PatchReservedDescriptors
;VulkanRenderState::BindDescriptorSet
;VK_KHR_push_descriptor
extension;VK_KHR_descriptor_update_template
extension;All lacking features have been "marked" with TODO comments in the codebase.
Known Issues:
Tested on:
GPUs:
Apps:
VK_KHR_ray_query
instead ofVK_KHR_ray_tracing_pipeline