search

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
8.88k stars 1.33k forks source link

Add missing Indirect resource usage for indirect draw count buffers #3296

Closed luckyxxl closed 5 months ago

luckyxxl commented 5 months ago

The buffer containing the uint32 draw count value for indirect draws with count was not marked as used as an indirect resource for the respective events of the following API calls: glMultiDrawArraysIndirectCount, glMultiDrawElementsIndirectCount, vkCmdDrawIndirectCount, vkCmdDrawIndexedIndirectCount, vkCmdDrawMeshTasksIndirectCountEXT

luckyxxl commented 5 months ago

Please note that I tested the change only for vkCmdDrawIndexedIndirectCount. I can could come up with minimal repros for vkCmdDrawIndirectCount and the GL calls maybe over the weekend if preferred.

luckyxxl commented 5 months ago

d3d12's ExecuteIndirect seems to mark the count buffer appropriately already.