Added shader viewer bookmarks and find shortcuts.

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.

https://renderdoc.org

MIT License

8.62k stars 1.3k forks source link

Added shader viewer bookmarks and find shortcuts. #3312

Closed ldecarufel closed 1 month ago

ldecarufel commented 1 month ago

Added shader viewer bookmarks and find shortcuts.

Ctrl-F3 and Ctrl-Shift-F3 can now be used to quickly search for the word under the cursor
Shader Viewer bookmarks: Ctrl-F2 to add a bookmark, F2/Shift-F2 to go to next/previous bookmark.
Context menu for bookmark actions, plus "Clear All Bookmarks".

qrenderdoc_siDJ8mY4XV

ldecarufel commented 1 month ago

I thought about adding buttons, but it was a tiny little bit more involved (need to find proper icons for a start!), so I decided to implement the functionality first, with context menu actions, and I'll add buttons in a separate commit. Does that make sense to you?

baldurk commented 1 month ago

That's totally fine, I'll leave this PR for you to add to.

For icons you can use these pngs from the same icon pack as the others: bookmark_red.png bookmark_red@2x.png

ldecarufel commented 1 month ago

Would these icons be ok for Toggle/Prev/Next Bookmarks? book_picture book_previous book_next

Or maybe this one for Toggle Bookmark?

baldurk commented 1 month ago

Yeh I saw that last one for toggle bookmark but I thought the simple bookmark was clearer. I wasn't thinking you'd need a button for previous/next as the main idea would be to let people see that a bookmarking feature exists at all - similar to find previous/next that can be left to context menus or shortcuts.

ldecarufel commented 1 month ago

Added a bookmark menu: qrenderdoc_kp4fjETjJe

I created the blue bookmark icon myself and combined it with some existing icons.

ldecarufel commented 1 month ago

Now using icons from standard icon set. Now disabling next/prev/clear menu items when there are no bookmarks.

qrenderdoc_vxDhTBIVSG