search

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
8.88k stars 1.33k forks source link

Identical expressions. Probably meant .width || .height #3377

Closed Sluggernot closed 3 months ago

Sluggernot commented 3 months ago

https://github.com/baldurk/renderdoc/blob/aa5538b2e92a266b9126c75f085abdc508597c10/renderdoc/core/image_viewer.cpp#L758

Line is if(texDetails.width > 16384 || texDetails.width > 16384)

Zorro666 commented 3 months ago

This does look a code mistake and would want to see this as a bug report with a reproduction to drive code change. In this case an image with width < 16384 and height > 16384 might create a bug

Zorro666 commented 3 months ago

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.

I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!

In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.

Sluggernot commented 3 months ago

Thanks. I am looking for real contributions to be made. I am trying to avoid being a contributor to the project through some cheap means like this.