search

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
9.06k stars 1.35k forks source link

DebugVertex: fix ShaderObject debugging #3439

Closed DHrpcs3 closed 2 months ago

DHrpcs3 commented 2 months ago

m_SPIRV was empty because of wrong ShaderModule

DHrpcs3 commented 2 months ago

I think the same fix needs to be applied to the other debug functions.

If I will need to use other shader debug functions and I will have fix for them, I will make PR for sure

baldurk commented 2 months ago

That's fine if you don't want to iterate on this PR, but in that case can you please close this and file an issue so it can be tracked for a full fix? As a reproducible test case it sounds like you could provide any shader object demo such as Sascha Willems' rather than yours specifically.

DHrpcs3 commented 2 months ago

What do you mean with don't want to iterate on this PR? Scope of this PR is fix debugging of vertex shader objects, not all shaders, not all issues in this repository. If it is not enough, sure I can close this PR or you can close it for me please.

Segfault can be reproduced by starting debugging of any vertex shader object which produces vertices, just click on any vertex in Mesh View and select Debug Vertex. You do not need to have special code, any example with shader objects should be enough.

baldurk commented 2 months ago

OK then, that's fine. I would appreciate if you could open an issue for this bug so that it can be properly tracked and a full fix made.