baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
9.07k stars 1.35k forks source link

Is there a bug here for replay Vulkan when call vkUnmapMemory #3460

Closed fuhaijin closed 1 month ago

fuhaijin commented 1 month ago

file:renderdoc/renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp function:Serialise_vkFlushMappedMemoryRanges, Calculate size like below: Serialise_vkFlushMappedMemoryRanges function:Serialise_vkUnmapMemory, Calculate size like below: Serialise_vkUnmapMemory

I think there's a problem with size calculation in function Serialise_vkUnmapMemory;if mapMemory use offset!=0,size is small,“size=finish - offs” could be a very large number。

baldurk commented 1 month ago

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.

I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!

In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.