search

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
9.06k stars 1.35k forks source link

Run clang-format in 8 threads #3463

Closed ShabbyX closed 3 weeks ago

ShabbyX commented 4 weeks ago

For faster runs of ./util/clang_format_all.sh

baldurk commented 3 weeks ago

I'm going to decline this because it looks like -P is not a standard xargs parameter so I don't know how portable this is. Normally it would be good enough, but since clang_format_all.sh should be rarely run I don't think this is worth making it potentially break somewhere.

Anyone who's developing regularly for RenderDoc should either have IDE integration format files, or use something like git clang-format to format only modified files. This brute force format of the whole repo is only used either for CI to check formatting or for someone who maybe doesn't care to properly set up clang-format at all. A minute to run the script in that case is not the end of the world.

ShabbyX commented 3 weeks ago

Ah interesting, didn't know about git clang-format. Thank you, that works.