search

baldurk / renderdoc

RenderDoc is a stand-alone graphics debugging tool.
https://renderdoc.org
MIT License
9.07k stars 1.35k forks source link

Add support for Vulkan Loader v1.3+ on Mac #3486

Closed jathoma98 closed 5 days ago

jathoma98 commented 1 week ago

Description

Per MacOS Vulkan SDK docs: (https://vulkan.lunarg.com/doc/view/latest/mac/getting_started.html)

"Beginning with the 1.3.216 Vulkan SDK, the Vulkan Loader is strictly enforcing the new VK_KHR_PORTABILITY_subset extension. The most likely cause of this error message on instance creation is failure to adhere to this extension, which prevents applications on all platforms from selecting by default a non-conformant Vulkan implementation without opting in. MoltenVK is currently not fully conformant, and thus supporting this extension is necessary for building robust and portable Vulkan-based applications that are good citizens in the Vulkan ecosystem.

This commit fixes VK_ERROR_INCOMPATIBLE_DRIVER on vkCreateInstance on MacOS by conforming to the above loader specification.

jathoma98 commented 5 days ago

We're maintaining the Meta fork of RenderDoc for Meta Quest devices, where replay is possible on Mac clients. The rationale makes sense, we'll keep this local on our fork, thanks!