search

baldwin-agency / magento2-module-less-js-compiler

Allows Magento 2 to compile less files using the less nodejs compiler
MIT License
23 stars 4 forks source link

Alternative Lessc compiler path + improve error message #3

Closed Echron closed 6 years ago

Echron commented 6 years ago

Try alternative paths for node Lessc compiler when not found in the .bin folder Improve error message when the node Lessc module is not found

hostep commented 6 years ago

Thanks!

I tweaked some small things from this PR. And you also gave me some inspiration to add another check to see if the node binary could be found or not, and if not found, another more user friendly error message is outputted.

(For next time, it's best to create a new branch on your fork, don't use v1-develop but a new branch based on that branch, it's easier to have a dedicated branch per pull request, otherwise pushing to the same branch might update older non-merged pull requests, just a hint in case you didn't already knew)

I'll create a new version with these changes in the next few days, want to test it a bit on different environments first.

hostep commented 5 years ago

Fix is available in version 1.1.2, thanks!