baldwin-agency / magento2-module-url-data-integrity-checker

Magento 2 module which can find potential url related problems in your catalog data

MIT License

261 stars 28 forks source link

Make module compatible with Magento 2.4 #10

Closed mbijnsdorp closed 4 years ago

mbijnsdorp commented 4 years ago

add @var to unit test (phpstan threw errors)
update composer dependencies according to Magento 2.4
update unit test to make it compatible

Due to the phpunit change, it's no longer backwards compatible with earlier versions of Magento. Let me know If you want to have additional changes or so because of it.

hostep commented 4 years ago

Thanks @mbijnsdorp!

I was planning on investigating compatibility with Magento 2.4.0 later this week, this PR will help me with that! I'll try to check it out in the coming days and get back to you!

hostep commented 4 years ago

Thanks for the PR @mbijnsdorp: it mostly looks fine, but I'll add some changes:

/** @var MockObject $productCollectionMock */ instead of /** @var \PHPUnit\Framework\MockObject\MockObject $productCollectionMock */
I'll update the PHPCompatibility tests, so it ignores the Tests in this module, since they are now no longer compatible with PHP 7.0 due to the added void return type, which is only supported in PHP 7.1 and higher

I'll create some extra commits to fix these things, then do a final review and do some manual tests. When everything looks fine, I'll tag a new release.

Thanks again!

hostep commented 4 years ago

@mbijnsdorp: unfortunately I found a regression in 2.4.0 with this module which needs additional research: #11

So I won't be tagging a new version until we've figured out a solution for that issue. I hope it won't take long to figure that out! 🙂

hostep commented 4 years ago

11 is fixed. Released v1.2.0

Thanks again!