Closed mbijnsdorp closed 4 years ago
Thanks @mbijnsdorp!
I was planning on investigating compatibility with Magento 2.4.0 later this week, this PR will help me with that! I'll try to check it out in the coming days and get back to you!
Thanks for the PR @mbijnsdorp: it mostly looks fine, but I'll add some changes:
/** @var MockObject $productCollectionMock */
instead of /** @var \PHPUnit\Framework\MockObject\MockObject $productCollectionMock */
void
return type, which is only supported in PHP 7.1 and higherI'll create some extra commits to fix these things, then do a final review and do some manual tests. When everything looks fine, I'll tag a new release.
Thanks again!
@mbijnsdorp: unfortunately I found a regression in 2.4.0 with this module which needs additional research: #11
So I won't be tagging a new version until we've figured out a solution for that issue. I hope it won't take long to figure that out! 🙂
@var
to unit test (phpstan threw errors)Due to the phpunit change, it's no longer backwards compatible with earlier versions of Magento. Let me know If you want to have additional changes or so because of it.