Configurable path update

DominicWatts commented 3 years ago

I installed on a multi-container environment and the hard coded direct is not a shared mount - so generated file on cron instance is not available on webserver instance

This commit adds option to configure path

hostep commented 3 years ago

Hi @DominicWatts

Terrible sorry for the long delay, but it was extremely busy in my personal and work life. Anyways, I spend some time today in looking at this PR and added some additional changes, you can view it on this branch: https://github.com/baldwin-agency/magento2-module-url-data-integrity-checker/commits/PR-28

Notable changes:

The configuration section was removed from a dedicated Baldwin tab to a new tab in the Catalog configuration section
I really don't like exposing those abstract constants configurations from the DirectoryList, because most people won't understand those, so I've chosen for people to be able to add either a relative path or an absolute path in the configuration field, which is more user friendly I believe. Unfortunately the code complexity exploded a bit by doing this, but so be it ...

I don't know if you would have a little bit of time to review those changes as well, and let me know if these changes will work for your case?

Thanks!

DominicWatts commented 3 years ago

Yep looks good

hostep commented 3 years ago

Thank you @DominicWatts for the PR, it has been published in release 1.3.0

baldwin-agency / magento2-module-url-data-integrity-checker

Configurable path update #28