search

baldwin-agency / magento2-module-url-data-integrity-checker

Magento 2 module which can find potential url related problems in your catalog data
MIT License
261 stars 28 forks source link

git hub actions #29

Open DominicWatts opened 3 years ago

DominicWatts commented 3 years ago

docker container based github actions to test code instead of makefile which for example relies on components being available locally. Plus get added automatic code scan on any PRs

key is in action so publicly visible but no reason couldn't utilise github secrets for key

this is more a demo of what can be done

Results look like this:

https://github.com/DominicWatts/magento2-module-url-data-integrity-checker/actions

You don't have to use container approach e.g. https://github.com/DominicWatts/Menu/blob/master/.github/workflows/standards.yml

However the reason I use container based approach is it's easier to switch php version and also for phpstan in particular not to throw false positives if components from M2 required modules are used : php_intl - e.g. IntlDateFormatter not found etc.

https://github.com/DominicWatts/PHPStan

But certainly container based unit tests are difficult

DominicWatts commented 3 years ago

plus you can give your project a nice badge

:1st_place_medal:

hostep commented 2 years ago

Thanks for the effort!

I really hope that those repo.magento.com credentials are not valid, otherwise I would strongly suggest you delete them and create new ones.

And I don't really agree with the changes in the phpstan.neon file. I want to be very explicit about which error to ignore in which file, otherwise it might mean that we hide warnings that shouldn't be hidden.

But I'll try to check it the PR out in more detail when I find some more time.