baldwin-agency / magento2-module-url-data-integrity-checker

Magento 2 module which can find potential url related problems in your catalog data
MIT License
261 stars 28 forks source link

Memory exhausted #32

Open mortenbirkelund opened 2 years ago

mortenbirkelund commented 2 years ago

Hitting the memory limit when trying to open product_url key report

The file size of the json file is 96mb and the memory limit is 1gb.

Anybody who can clarify why it was decided to store these reports in the filesystem instead of the database?

hostep commented 2 years ago

Hi @mortenbirkelund

Slightly related issue: https://github.com/baldwin-agency/magento2-module-url-data-integrity-checker/issues/13

Yes, it was a mistake to store the results in json files and not in the database. There was no good reason for database storage when first writing this module, I never expected people to have soo many problems. But it turns out that certain shops occasionally do have so many problems.

It' on the roadmap to rewrite this storage, but it has been for a while and I didn't find the time or energy for it yet. So don't expect this to be fixed soon, sorry about that!

If you want a quick fix, I would recommend you try to fix as many problems as possible and then to retry it again.

hostep commented 2 years ago

Hey @mortenbirkelund

I've just released version 1.4.0 of this module, which comes with an option to disable checking problems for invisible products. Reasons for this have been discussed in #31 I think that enabling this option could maybe fix your issue in case you have a lot of invisible products in your shop.

I'm not considering this issue fixed though, we still need to rewrite the storage to use the database instead of json files.