search

baldwin-agency / magento2-module-url-data-integrity-checker

Magento 2 module which can find potential url related problems in your catalog data
MIT License
261 stars 28 forks source link

Remove unnecessary setup version #33

Open sprankhub opened 2 years ago

sprankhub commented 2 years ago

If I am not mistaken, this module does not rely on any setup / upgrade scripts. Hence, there is no need for a setup version. Having it still in the config means that we cannot have a zero-downtime-deployment when deploying this module (since bin/magento setup:db:status will say updates are necessary).

hostep commented 2 years ago

Thanks @sprankhub, but this module still supports Magento 2.1 and 2.2 currently (but maybe that will change in the future someday) and in those older versions this version declaration is still mandatory.

About the zero-downtime-deployment: this only happens when first installing the module I'm assuming? On further deployments it will work fine, right?

sprankhub commented 2 years ago

Then please stop supporting 2.1 and 2.2 :joy:

Yes, this is a one-time issue. It is still annoying to have unnecessary downtime, though.

Thanks as usual :)