search

balena-io-experimental / balena-cam-uv4l

a Raspberry Pi based network camera
Apache License 2.0
30 stars 13 forks source link

Fix uv4l configuration file construction #7

Closed mbalamat closed 6 years ago

zrzka commented 6 years ago

Also I'd recommend to read Resin Commit Guidelines Proposal. It's just a proposal, but many projects already do obey these rules. Especially when you said:

okay I think I've fixed the issue for this one.

Something like ...

core: Fix uv4l configuration file construction

Connects-to: #123
Change-type: patch
Signed-off-by: Name <email@resin.io>

... can do the trick. Also check resin-commit-lint project for more details. It's good to learn these things, so, you can do it naturally when you commit to any project outside of playground with version bot involved, etc.

nistath commented 6 years ago

What is the issue here in the first place?

mbalamat commented 6 years ago

Hi @nistath I am trying to fix #5 and #6

nistath commented 6 years ago

@mbalamat I am fairly certain those are issues with UV4L, although I haven't had a chance to reproduce. The current code works fine w.r.t. editing the configuration file.

mbalamat commented 6 years ago

@nistath I've reproduced it, and I think this PR fixes it. I am actually stepping on your footsteps, so thanks for your contribution!

zrzka commented 6 years ago

Merged based on @mbalamat request:

Good morning Robert! Would you mind checking the PR and merge it if everything is ok?