search

balena-io-experimental / balena-sound

Build a single or multi-room streamer for an existing audio device using a Raspberry Pi! Supports Bluetooth, Airplay and Spotify Connect
https://balena.io/blog/turn-your-old-speakers-or-hi-fi-into-bluetooth-receivers-using-only-a-raspberry-pi/
MIT License
2.39k stars 427 forks source link

Build librespot 0.4.2 in container (fixes #589) #610

Closed andrewn closed 1 year ago

andrewn commented 1 year ago

Spotify playback is broken in librespot 0.3.1 and depending on tmigone/librespot:0.3.1-pulseaudio means we can't easily upgrade to the latest version.

Building within the project allows us to choose which version is tracked by balena-sound, as suggested here.

I pushed this to a balena device and it builds correctly and plays Spotify.

Fixes #589

maggie44 commented 1 year ago

This looks good to me. I had considered whether we should bump the final container up to alpine:3.16-run as well, but if it's not broken don't fix it, as the motto goes. I think it makes sense to leave it like this where we know the package versions work.

You can add Fixes: https://github.com/balena-labs-projects/balena-sound/issues/589#issuecomment-1310072186 in your post body for this PR and it will link the two together, and close the issue when we merge it.

I haven't got the capacity to test this out, but we trust you. Are you happy for this to be merged, and to take the heat from the BalenaSound community if they come knocking? ;).

andrewn commented 1 year ago

You can add Fixes: https://github.com/balena-labs-projects/balena-sound/issues/589#issuecomment-1310072186 in your post body for this PR and it will link the two together, and close the issue when we merge it.

I think that also works by including the issue number in the PR title (or a commit).

andrewn commented 1 year ago

I haven't got the capacity to test this out, but we trust you. Are you happy for this to be merged, and to take the heat from the BalenaSound community if they come knocking? ;).

Well, it works for me, and it's currently totally broken in the latest release so I guess we can give it a go 😄