balena-io-experimental / browser

A drop-in web browser block
102 stars 80 forks source link

Patch: Update chromium flag #147

Closed beda closed 1 year ago

beda commented 1 year ago

The flag got renamed to --ignore-gpu-blocklist otherwise Hardware acceleration does not work

klutchell commented 1 year ago

Thanks for the contribution!

Can you please add a Change-type: patch to the body of your commit message?

You can find the guidelines for our semantic versioning system here: https://github.com/balena-io/docs/blob/master/CONTRIBUTING.md#creating-commits-in-line-with-semantic-versioning

jellyfish-bot commented 1 year ago

[rosswesleyporter] This has attached https://jel.ly.fish/a28a81b3-5f7e-4c08-8a29-6d5643f0a0ae

acostach commented 1 year ago

Hi @beda , Change-type and Signed-off-by are needed in the commit message body and not in the title, otherwise the versioning checks will not pass. To do this, you can follow these steps:

git commit --amend

edit the message body to resemble the following one:

Update chromium flag

The flag got renamed to --ignore-gpu-blocklist otherwise Hardware acceleration does not work

Change-type: patch
Signed-off-by: Your Name <your@email.com>

save the changes and then git push origin beda --force

beda commented 1 year ago

Hi Alexandru

Thanks for the step by step explanation. I think I now got it right.

Best

Beda

made Marketing Beda Binder Seestrasse 37 8002 Zürich

+41 79 707 93 40 www.mademarketing.ch https://www.mademarketing.ch/

Am 27.07.2023 um 12:48 schrieb Alexandru Costache @.***>:

Hi @beda https://github.com/beda , Change type and Signed-off-by are needed in the commit message body and not in the title, otherwise the versioning checks will not pass. To do this, you can follow these steps:

git commit --amend edit the message body to resemble the following one:

Update chromium flag

The flag got renamed to --ignore-gpu-blocklist otherwise Hardware acceleration does not work

Change-type: patch Signed-off-by: Your Name @.***> save the changes and then git push origin beda --force

— Reply to this email directly, view it on GitHub https://github.com/balena-labs-projects/browser/pull/147#issuecomment-1653371792, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUBSKPVHWLZZSZVI6EDVDXSJBP5ANCNFSM6AAAAAAZZ3LKPI. You are receiving this because you were mentioned.

acostach commented 1 year ago

The flag was changed in upstream commit https://chromium.googlesource.com/chromium/src/+/49c0110d8c500c1c4765ed37c05eca64699f5779

acostach commented 1 year ago

lgtm