balena-io-experimental / browser

A drop-in web browser block
102 stars 80 forks source link

Removes wget package from dockerfile #151

Closed Iznogohul closed 1 year ago

Iznogohul commented 1 year ago

Change-type: patch Removes the 'wget' package from the Dockerfile template, resulting in a Docker image size reduction to approximately 754.92MB (compared to ~755.86MB). Every bit counts, right? #42

P.S.:

Also noticed this branch about updating the base image to Debian 12 for Balena Browser. Woulid be awesome to have latest stable software with the same functionality however, it's worth mentioning that going with Debian 12 (Bookworm) would significantly increase the Docker image size to 1 GB+. This got me thinking about alternative approaches. To ensure both the latest mesa version and a relatively small Docker image, I decided to undertake a rewrite of the project here

Rewrite inclues

klutchell commented 1 year ago

Thanks for the contribution!

Can you please add a Change-type: patch to the body of your commit message?

You can find the guidelines for our semantic versioning system here: https://github.com/balena-io/docs/blob/master/CONTRIBUTING.md#creating-commits-in-line-with-semantic-versioning

Iznogohul commented 1 year ago

@klutchell Took me a while but made the correct patch commit

klutchell commented 1 year ago

Could you also squash those 5 commits into one from the command line? https://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git-squash/13231

Iznogohul commented 1 year ago

@klutchell should be fine now

klutchell commented 1 year ago

lgtm!