balena-io-experimental / browser

A drop-in web browser block
96 stars 70 forks source link

/usr/bin/entry.sh is executed twice #162

Open kohnw opened 7 months ago

kohnw commented 7 months ago

we removed line /usr/bin/entry.sh echo "Running balena base image entrypoint..." from /usr/src/app/start.sh as this /usr/bin/entry.sh is already being run as an entrypoint by Dockerfile and thus it was being run twice and udev deamon as well twice, which is wrong...

Running two udev daemons caused issues with reconnecting USB devices.

kohnw commented 6 months ago

Is there anything which i can do to proceed with this merge request?

phil-d-wilson commented 6 months ago

Hi @kohnw - thank you for the nudge! I'm really sorry, I was trying to push this along and got distracted, many many times. :)

You need to edit your commit so that the commit message includes a Change-type. You can see an example of this on this PR. Flowzone requires this so that it can bump the semver in the correct way.

Phil