search

balena-io-experimental / browser

A drop-in web browser block
98 stars 75 forks source link

change of user-dir (using PERSISTENT=1) isn't passed to chrome-launcher #97

Closed ostollmann closed 2 years ago

ostollmann commented 2 years ago

https://github.com/balenablocks/browser/blob/af0effb01aca60f1218f1601449a66bedec2073a/src/server.js#L144

should pass the user-dir to chrome-launcher

https://github.com/GoogleChrome/chrome-launcher/blob/30755cde8627b7aad6caff1594c9752f80a39a4d/src/chrome-launcher.ts#L38

phil-d-wilson commented 2 years ago

Thank you for the PR! I've merged it in, but I'm doing some more fixes and will roll out a new version when I'm done..