search

balena-io-experimental / browser

A drop-in web browser block
99 stars 77 forks source link

Use chrome-launcher's userDataDir #98

Closed ostollmann closed 2 years ago

ostollmann commented 2 years ago

The current implementation leads to log files being written to another directory because of https://github.com/GoogleChrome/chrome-launcher/blob/30755cde8627b7aad6caff1594c9752f80a39a4d/src/chrome-launcher.ts#L211.

This uses chrome-launcher's userDataDir prop instead of the custom flag. It works because chrome-launcher sets the same flag that was previously being set; see: https://github.com/GoogleChrome/chrome-launcher/blob/30755cde8627b7aad6caff1594c9752f80a39a4d/src/chrome-launcher.ts#L175

ghost commented 2 years ago

Your landr site preview has been successfully deployed to https://landr-o1iver-repo-browser.netlify.app

Deployed with Landr 7.1.0