balena-io-experimental / meetbot

A Google Meet bot to make meetings frictionless
GNU Affero General Public License v3.0
31 stars 13 forks source link

Start/stop recording when people are meet > 2 #79

Closed vipulgupta2048 closed 2 years ago

vipulgupta2048 commented 2 years ago

Starting/Stopping the recording when there are more than 2 people in the call seems like a nice tweak to meetbot recording behavior. Also prevents the over extending of the calls.

FD: https://www.flowdock.com/app/rulemotion/r-beginners/threads/yUhHN4GmeRDIY9GL9LW2pBXgAin

hraftery commented 2 years ago

If the stop is terminal, will falsely trigger in the scenario of a one-on-one call, where one person logs off to fix Internet/microphone/camera issues. Particularly bad if it's as people are entering...

codewithcheese commented 2 years ago

~I think @Page-'s point was it should start when 2 humans are in the call not including meetbot, and pause when there is less than 2 humans~ nevermind, I see by people you mean attendees, humans and bots

vipulgupta2048 commented 2 years ago

Particularly bad if it's as people are entering...

@hraftery Developing meetbot is very close to automating/mimicking human behavior. While we can't fully account for this, what I can do is extend meetbot's time in the meet before it up and quits.

vipulgupta2048 commented 2 years ago

Folks, I have created a partial solution for this issue. The recording will only start when there is more than 2 people on the call

There aren't any changes to the stop recording behavior. This will at least be of some improvement as stop the recording brought some of its own problems which I chose to not deal at this moment. Some of them were: