search

balena-io-experimental / t-buildroot-kconfig

1 stars 0 forks source link

Tests did not catch typo #3

Open rahul-thakoor opened 2 years ago

rahul-thakoor commented 2 years ago

https://github.com/balena-io-playground/t-buildroot-kconfig/blob/7b5ffcb07caa22ee382f99199a2ec92f0dd5f845/examples/e1.yaml#L1

hey @Hades32 any idea why the tests did not pick this up?

should be type-balena-io-playground-t-buildroot-kconfig@1.0.0 right?

Hades32 commented 2 years ago

@rahul-thakoor he reason is that I currently just test if a field type exists and is a string, but not the exact format. I want to improve that, but don't wont to duplicate the logic between the transformer and JF core. Can you move this issue to t-type-source-to-type?