search

balena-io-hardware / etcherPro-fleet-sw

balenaEtcher on EtcherPro hardware
10 stars 8 forks source link

Flash doesn't set an update lock #27

Open aethernet opened 1 year ago

aethernet commented 1 year ago

When flashing, no update locks is set.

Which means a configuration change or a fleet update would restart EP services even if in the middle of a flash.

This should probably be addressed in etcher itself instead of EP, even if specific to running etcher on EP.

builder555 commented 1 year ago

@aethernet the lack of locks id definitely a problem.

on its own etcher shouldn't care (or know) if it's running as a standalone application on a PC or in a container on EP.

i think the ideal solution would be: etcher exposes status or events (e.g. 'source detected', 'flashing started', etc). EtcherPro listens to those events and sets/removes locks accordingly.

aethernet commented 1 year ago

This sounds like a good plan