search

balena-io-hardware / testbot-sdk-sw

Node SDK for controlling and performing operations with testbot
https://www.npmjs.com/package/@balena/testbot
Apache License 2.0
4 stars 0 forks source link

lib: Add Pi3 243390 support #21

Closed acostach closed 2 years ago

acostach commented 2 years ago

Change-type: patch Signed-off-by: Alexandru Costache alexandru@balena.io

rcooke-warwick commented 2 years ago

@acostach since merging your other PR there are some merge conflicts now

acostach commented 2 years ago

Thanks for letting me know Ryain, I'll update it as soon as flashing works, as there are some issues with the upstream usbboot firmware

acostach commented 2 years ago

Would it be possible to update etcher-sdk to the latest version in leviathan @rcooke-warwick ? Updating rpi firmware blobs in node-raspberrypi-usbboot would imply using the latest etcher sdk, currently it's at v2.0.2 in leviathan and upstream is v7.0.0

acostach commented 2 years ago

Relies on https://github.com/balena-io-modules/etcher-sdk/pull/227 getting merged first

acostach commented 2 years ago

@rcooke-warwick I've updated the PR to bring in etcher-sdk 7.0.1 and fixed the build errors that happened due to the update, however, with this PR the CM3 does not enter MSD mode and I suspect it might be because of the fixes I did so that the lint checks could pass.

I have tested the node-raspberrypi-usbboot module included in this and the CM3 and custom RPi are put in MSD mode:

testbot/node-raspberrypi-usbboot$ sudo npx ts-node lib/main.ts   -> CM3
Waiting for BCM2835/6/7
device attached 1-2
progress 1-2 0 %
progress 1-2 3 %
progress 1-2 5 %
progress 1-2 8 %
progress 1-2 10 %
progress 1-2 13 %
progress 1-2 15 %
progress 1-2 18 %
progress 1-2 20 %
progress 1-2 23 %
progress 1-2 98 %
progress 1-2 100 %
device 1-2 is ready
device 1-2 detached
^C
~/testbot/node-raspberrypi-usbboot$ sudo npx ts-node lib/main.ts ---> custom RPI with eMMC
Waiting for BCM2835/6/7
device attached 1-2
progress 1-2 0 %
progress 1-2 3 %
progress 1-2 5 %
progress 1-2 8 %
progress 1-2 10 %
progress 1-2 13 %
progress 1-2 15 %
progress 1-2 18 %
progress 1-2 20 %
progress 1-2 23 %
progress 1-2 98 %
progress 1-2 100 %
device 1-2 is ready
device 1-2 detached
^C

However it might be that the FINs sequence need some updating because it stays in "Waiting for compute module" .. Can you please check if the FIN sequence needs updating after this etcher-sdk update? Thank you

acostach commented 2 years ago

Hi @rcooke-warwick , friendly reminder about this :)

acostach commented 2 years ago

@balena-ci rebase

rcooke-warwick commented 2 years ago

@acostach we just merged a fix for the testbot sdk for fin flashing - the problem you were seeing Waiting for compute module was an existing problem, probably not related to your change. It was related to the USB hub not responding to uhubctl.

I would recommend now retrying your tests on this PR, maybe it will work now

acostach commented 2 years ago

Ack, thanks Ryan , I'll try again with the new fixes

acostach commented 2 years ago

Thanks @rcooke-warwick , I've updated the branch to include the uhubctl fix but the CM3 still doesn't enter MSD mode. Does this branch, as it is now with the etcher-sdk update put the Fin in msd mode on your side?

acostach commented 2 years ago

@balena-ci rebase

acostach commented 2 years ago

@rcooke-warwick friendly reminder about this, if you can give this PR a spin

acostach commented 2 years ago

@balena-ci rebase

acostach commented 2 years ago

Hi @rcooke-warwick ,did you get the chance to test this on the CM3?

acostach commented 2 years ago

Let's close this PR for now and use the newer https://github.com/balena-io-hardware/testbotsdk/pull/36 cc @rcooke-warwick