balena-io-modules / analytics-client

Client part of analytics services used at balena
5 stars 0 forks source link

Add URL query string tools #1

Closed roman-mazur closed 5 years ago

roman-mazur commented 5 years ago

AnalyticsUrlParam class encapsulates the logic of handling passed URL parameters with anonymous device identifier.

Change-type: minor Signed-off-by: Roman Mazur roman@balena.io

nazrhom commented 5 years ago

@balena-ci retest

roman-mazur commented 5 years ago

@balena-ci retest please

roman-mazur commented 5 years ago

@balena-ci retest please

roman-mazur commented 5 years ago

@balena-ci retest please

webpack output is re-configured

roman-mazur commented 5 years ago

Example of the compiled bundle served via unpkg: https://unpkg.com/analytics-client@0.1.0-roman-url-params-431f6998b0134ff6209577529d1d3737fc8b1bbe/dist/bundle.js

roman-mazur commented 5 years ago

@sradevski your comments should be addressed now.

roman-mazur commented 5 years ago

@balena-ci retest please

roman-mazur commented 5 years ago

@balena-ci retest please

roman-mazur commented 5 years ago

@balena-ci retest again, please both TS and webpack outputs are now in the dist folder

roman-mazur commented 5 years ago

@balena-ci retest please, again

roman-mazur commented 5 years ago

@balena-ci retest please

roman-mazur commented 5 years ago

lodash dependency is removed now, Set is used to maintain device IDs.

@balena-ci retest, please