search

balena-io-modules / balena-compose

Complete toolkit for building docker-compose.yml files and optionally deploy them on balenaCloud
Apache License 2.0
8 stars 0 forks source link

Support a wider range of object label characters #12

Open kb2ma opened 2 years ago

kb2ma commented 2 years ago

Presently the acceptable characters for a label on a service, network, or value are limited to ASCII letters and numbers, plus period (.) and dash (-). Supervisor is expanding the set of acceptable characters to support services like traefik and caddy-docker-proxy.

We want to support this extension of acceptable characters across all balena tools. balena-cli relies on balena-compose for label validation.

andoks commented 2 months ago

I just got an error Invalid label name: "caddy.handle_path". Label names must only contain alphanumeric characters, periods "." and dashes "-". when trying to do balena push using balena-cli 18.2.33 and supervisor v16.4.4 (and host os balenaOS 2.115.7+rev1) - I found https://github.com/balena-os/balena-supervisor/issues/1949 and was thinking it should work with https://github.com/balena-os/balena-supervisor/pull/2000 merged, but I still got the error. can #13 be merged now? I there a work-around for this?

andoks commented 2 months ago

Related issue over at the lucaslorentz/caddy-docker-proxy project https://github.com/lucaslorentz/caddy-docker-proxy/issues/362