search

balena-io-modules / balena-compose

Complete toolkit for building docker-compose.yml files and optionally deploy them on balenaCloud
Apache License 2.0
8 stars 1 forks source link

Allow most printable ASCII chars for object label key (b-c) #13

Open kb2ma opened 2 years ago

kb2ma commented 2 years ago

Ensure all dependents of this package work before merging this PR!

Extends acceptable label characters to printable ASCII characters except space, single/double quotes and backtick. Updates minimal acceptable version of @types/dockerode to ensure build succeeds.

As of 2023-03-22 this PR still is blocked on an overall system solution between clients and server. This PR is useful; however older clients likely will fail in some way if they receive a service containing the extra characters.

Fixes #12

dfunckt commented 2 years ago

We need to make sure the Supervisor never applies labels to containers/images because I think Docker will error.

Also, please do not merge before the rest of product is prepared to handle this change.

kb2ma commented 2 years ago

We need to make sure the Supervisor never applies labels to containers/images because I think Docker will error.

I created a PR on the Supervisor to accept a Target State with the expanded character set. I'll verify it does not apply a label itself.

kb2ma commented 2 years ago

Also, please do not merge before the rest of product is prepared to handle this change.

What preparation is required for balena-builder? balena-cli seems to work OK with the updated character set. IIRC I can balena container inspect a container with expanded characters.

dfunckt commented 2 years ago

I mean please do not merge this PR before the Supervisor one is merged and deployed. Also, it’s typically better to introduce changes to the builder first and then the CLI.