search

balena-io-modules / balena-compose

Complete toolkit for building docker-compose.yml files and optionally deploy them on balenaCloud
Apache License 2.0
8 stars 1 forks source link

Replace balenaCI & circleCI with flowzone #14

Closed thgreasi closed 2 years ago

thgreasi commented 2 years ago

Change-type: patch

kb2ma commented 2 years ago

@thgreasi , I would like to make progress on this PR and #11, on which this PR is based. Here is my proposal. Please bear with me because it requires some explanation.

Merge #11 to unblock this PR

As you can see on the tests for this PR, there are test failures. I added commit 2883800 on #11 to resolve the failures. The tests pass on my workstation, but fail on #11 as you can see here. This failure seems to be specific to CircleCI.

The failure seems to be due to a null value for DOCKER_CERT_PATH env variable. I would rather ignore that failure than figure it out since we are moving to Flowzone in this PR. However to justify this step, this PR needs to pass tests.

Update this PR to pass tests

I created #16 to test the content of this PR with commit 2883800. Unfortunately it failed this test that passes on my workstation. The failure is Error: The command '/bin/sh -c ping -c3 foo' returned a non-zero code: 1.

Exit status 1 on ping means the actual ping failed. The test actually tests use of the Docker extra_hosts property, and the foo reference in the command above is to IP address 8.8.8.8. I would expect that address to be available, so I tried use of 127.0.0.1 in commit 159df16 on #16 -- and that address works!

So, do you know why use of address 8.8.8.8 would fail in the Flowzone test? I would guess something is blocking networking.

Endgame

If we can get the tests on #16 to pass, then we can do the steps below. Let me know what you think.

  1. I merge (#)11
  2. You rebase this PR from the merge
  3. Resolve the issue above with the Flowzone test, and append whatever commits are necessary to this PR
  4. Merge this PR.
  5. I can finish/merge (#)13, which was my original goal before I got into this swamp. ;-)
thgreasi commented 2 years ago

@kb2ma I guess that the 8.8.8.8 request in flowzone fails b/c of See: https://github.com/product-os/flowzone/blob/19273966f256a966eacc25195393ce98701aba33/tests/docker-compose.test.yml#L15-L16

kb2ma commented 2 years ago

Thanks for the link to docker-compose @thgreasi , and thanks for pushing through #11 and #16 ! Since #16 included the commit here, I'll close this PR.