search

balena-io-modules / balena-preload

Script for preloading containers onto balena device images
https://www.balena.io/
Apache License 2.0
35 stars 8 forks source link

Update supervisor image regex to include tagged images #272

Closed klutchell closed 2 years ago

klutchell commented 2 years ago

Starting in balenaOS v2.93.0 the supervisor images are tagged as balena_supervisor after being pulled from the balena registry.

Change-type: patch Signed-off-by: Kyle Harding kyle@balena.io See: https://github.com/balena-os/meta-balena/pull/2473 Fixes: https://github.com/balena-io-modules/balena-preload/issues/271

klutchell commented 2 years ago

Odd that this error is appearing now, unrelated to these changes.

lib/preload.ts:1148:71 - error TS2345: Argument of type '{ authconfig: { registrytoken: any; }; }' is not assignable to parameter of type 'PullPushOptions'.
  Types of property 'authconfig' are incompatible.
    Type '{ registrytoken: any; }' is not assignable to type 'AuthConfig & { auth?: string | undefined; registrytoken?: string | undefined; }'.
      Type '{ registrytoken: any; }' is missing the following properties from type 'AuthConfig': username, password, serveraddress

1148     return innerDockerProgress.pull(image, onProgressHandlers[index], opts);
klutchell commented 2 years ago

@balena-ci retest

klutchell commented 2 years ago

@balena-ci retest