search

balena-io-modules / balena-preload

Script for preloading containers onto balena device images
https://www.balena.io/
Apache License 2.0
35 stars 8 forks source link

Upgrade dockerode to v4.0.2 #288

Closed kb2ma closed 6 months ago

kb2ma commented 6 months ago

Upgrade dockerode to v4 so will be on the same version as balena-cli, where preload is used.

Just running the test target generated a couple of errors like below, so updated the balena linter. This required a switch to eslint based comments.

The 'no-shadowed-variable' rule threw an error in 'lib/preload.ts':
TypeError: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead.
    at /home/kbee/dev/balena-preload/repo/node_modules/typescript/lib/typescript.js:172041:13
    at IdentifierObject.<anonymous> (/home/kbee/dev/balena-preload/repo/node_modules/typescript/lib/typescript.js:172071:7)
    at Object.isThisParameter (/home/kbee/dev/balena-preload/repo/node_modules/tsutils/util/util.js:36:79)
    at cb (/home/kbee/dev/balena-preload/repo/node_modules/tslint/lib/rules/noShadowedVariableRule.js:208:36)
    at visitNodes (/home/kbee/dev/balena-preload/repo/node_modules/typescript/lib/typescript.js:28081:24)
    ...