search

balena-io-modules / balena-procbots

Process bots used for automating the development and deployment CI pipeline
https://balena-io-modules.github.io/balena-procbots/
Apache License 2.0
7 stars 3 forks source link

VersionBot: Don't mention `repository.yml` in errors when no repository.yml exists #317

Open lurch opened 6 years ago

lurch commented 6 years ago

See the conversation in https://github.com/resin-io/resin-ssh-keys/pull/44

The commit in that PR was missing a Change-type: footer-tag, and VersionBot then displayed a

Versionist — Missing or forbidden tags in commits, see `repository.yml`

failing status-message, which is a bit confusing when the https://github.com/resin-io/resin-ssh-keys repo doesn't actually have a repository.yml file!

pimterry commented 6 years ago

This is especially a problem for PRs from external contributors.

Something like "PRs must include a 'Change-Type: patch/minor/major' footer" would be understandable I think, but as is they get a message that's definitely not going to make sense, and they're stuck. Example: http://github.com/resin-io/docs/pull/653