Update to newest version of webpack

balena-io-modules / balena-temen

Balena TEMplating ENgine

Apache License 2.0

2 stars 1 forks source link

Update to newest version of webpack #64

Closed cyplo closed 5 years ago

cyplo commented 5 years ago

Updated all dependencies in the browser example project to avoid it being affected by wasm loading issue - https://github.com/webpack/webpack/issues/8781

cyplo commented 5 years ago

Tested manually as I don't think we run the examples through CI - maybe we should - @zrzka ?

cyplo commented 5 years ago

@nazrhom @zrzka - the CI fails for this change here - it's a problem with the rustup component version - the same change passed CI for jellyschema here Do I need to change something about this repo or is it a concourse/image issue ?

zrzka commented 5 years ago

@cyplo IMHO we can leave them out of CI. These're just examples how to use it. And to run them through CI, we have to change package.json to file:../../target/npm/pkg, because the version isn't published yet. Then the examples folder name will be kind of misleading, because you wont be able to run them out of CI if you don't modify package.json to point to some version, ... Probably not worth the hassle.

cyplo commented 5 years ago

I'm gonna remove rust-toolchain as see what's up