search

balena-io-modules / device-diagnostics

on-device diagnostics tool
9 stars 8 forks source link

Add proper check dependencies #172

Open xginn8 opened 4 years ago

xginn8 commented 4 years ago

Since many checks depend on other lower-level checks (for example, the supervisor requires a functional container engine), we should be cognizant of that and express that programmatically to reduce the likelihood of false positives. As a start, we can easily express that in documentation.

jellyfish-bot commented 4 years ago

[xginn8] This issue has attached support thread https://jel.ly.fish/#/1106b429-94a1-46aa-969e-7a86f0075406

jellyfish-bot commented 4 years ago

[xginn8] This issue has attached support thread https://jel.ly.fish/#/ecd9ab7a-71a9-4d11-a6cf-e88a277b3b90

srlowe commented 4 years ago

Connected to this, these network healthchecks can sometimes be a bit misleading, as they are expected to fail if balenaEngine is not running. It would be good if they were marked as expected when balenaEngine is known not to be running (or just a note), so that support agents don't spend time diagnosing network issues when there may be none.

test_dockerhub: Could not query Docker Hub
test_balena_registry: Could not communicate with registry2.resin.io for authentication