DNS checks should only use the active DNS servers - Githubissues

balena-io-modules / device-diagnostics

on-device diagnostics tool

9 stars 8 forks source link

DNS checks should only use the active DNS servers #280

Closed klutchell closed 3 years ago

klutchell commented 3 years ago

Expected Behavior

DNS checks should only use the active DNS servers.

Actual Behavior

DNS checks will use all DNS servers found in the dnsmasq journalctl logs and report on the first one to fail.

Steps to Reproduce the Problem

provision an unreachable DNS server in config.json or via DHCP
change to a valid DNS server in config.json or via DHCP
run checks in dashboard and see invalid server tested and failed

Specifications

balenaOS: 2.80.5+rev1
Device type: Variscite DART-MX8M Mini NRT
Supervisor: 12.8.7

References

https://github.com/balena-io-modules/device-diagnostics/blob/99fda797aa80d8cfdc139f8f2c7ceca6ffbfe586/scripts/checks.sh#L100

jellyfish-bot commented 3 years ago

[klutchell] This issue has attached support thread https://jel.ly.fish/5bbc6463-d257-4e0a-b4a3-2597427bbd8f

jellyfish-bot commented 3 years ago

[klutchell] This issue has attached support thread https://jel.ly.fish/276189df-6974-4ae0-8f9f-9e750f58d180