Closed myarmolinsky closed 2 years ago
I just noticed there are already some TODO
s in that function!
https://github.com/balena-io-modules/device-diagnostics/blob/6eb9b6dd5f43032856a7aba166aaa62c79dba1b8/scripts/checks.sh#L569-L590
@myarmolinsky do you still have the screenshot you took of the current behaviour that you could attach here?
Expected Behavior
If a user surfaces healthchecks for a service's container and they pass but the user has not provided a success message, we show a default success message like "SERVICE_NAME is healthy". Perhaps the same should be done with errors (if necessary) i.e. "SERVICE_NAME failed healthchecks"
Actual Behavior
If a user surfaces healthchecks for a service's container and they pass but the user has not provided a success message, we see
'exit code: 0, output: '
which is not meaningfulSteps to Reproduce the Problem
'exit code: 0, output: '
instead of anything meaningful