search

balena-io-modules / device-diagnostics

on-device diagnostics tool
9 stars 8 forks source link

make check_balenaOS account for prod/dev merge #302

Closed rcooke-warwick closed 2 years ago

rcooke-warwick commented 2 years ago

A user brought to our attention on support that they were getting a failed health check on the RPI4, version 2.88.5+rev1, saying that their OS version wasn't available on the API.

After looking into it, the check was failing because of the prod/dev merger of OS images starting at OS v.2.88.5. The check_balenaOs check tries to find a matching variant + version combination, I made a patch to make it only check the version. AFAIK, prod + dev for older OS releases happened at the same time anyway, so removing the variant check shouldn't cause a problem?

Change-type: patch Signed-off-by: Ryan Cooke ryan@balena.io

jellyfish-bot commented 2 years ago

[rcooke-warwick] This pull request has attached support thread https://jel.ly.fish/0de5a78f-48e0-4952-b270-bef36250428d

rcooke-warwick commented 2 years ago

@balena-ci rebase

alexgg commented 2 years ago

@klutchell @thgreasi is this just pending re-review?

klutchell commented 2 years ago

@klutchell @thgreasi is this just pending re-review?

Just waiting for the remaining comments to be addressed and squashed

rcooke-warwick commented 2 years ago

@klutchell done! Tested the script on a pi3-64bit (v.2.94, with the dev/prod unification) and a fin v2.83 (separate dev/prod releases).