balena-io-modules / device-diagnostics

on-device diagnostics tool
9 stars 8 forks source link

`check_balenaOS` fails when there is no internet connectivity #313

Open 20k-ultra opened 2 years ago

20k-ultra commented 2 years ago

The check_balenaOS needs to check if the current version on the device is in api.balena-cloud.com. The problem is, when the device does not have a working internet connection than this check gives a false positive saying the OS is not available in the API but really the check just failed to reach the API!

A warning message saying "Could not reach api" or something should be used.

Exact error when there's no internet:

balenaOS 2.x detected, but this version is not currently available in https://api.balena-cloud.com

I know there is no internet because this check also fails:

Some networking issues detected: test_balena_api: Could not contact https://api.balena-cloud.com test_balena_registry: Could not communicate with registry2.balena-cloud.com for authentication test_ipv4_stack: Could not contact https://ipv4.google.com