Fix ARG handling in transposition

balena-io-modules / docker-qemu-transpose

Alter a Dockerfile to allow emulated builds without binfmt

Apache License 2.0

3 stars 0 forks source link

Fix ARG handling in transposition #7

Closed CameronDiver closed 7 years ago

CameronDiver commented 7 years ago

ARG lines were being parsed as having arguments in an array, and this was causing the output to be wrong in the resulting Dockerfile. This PR adds special-case handling for ARG lines.

Change-type: patch Connects-to: #6 Signed-off-by: Cameron Diver cameron@resin.io ---- Autogenerated Waffleboard Connection: Connects to #6

CameronDiver commented 7 years ago

Agreed on the tests. I'll make an issue and get to it as soon as I can.

resin-io-modules-versionbot[bot] commented 7 years ago

VersionBot failed to commit a new version to prepare a merge for the above pull request here: https://github.com/resin-io-modules/docker-qemu-transpose/pull/7. The reason for this is: Command failed: /usr/src/app/node_modules/.bin/versionist Omitting v0.2.1. No valid git reference was found. Join our Gitter channel if you need any help! https://gitter.im/resin-io/versionist

Please carry out relevant changes or alert an appropriate admin.